Add EIP: Delegatable Utility Tokens Derived from NFTs #6884

blgaman · 2023-04-16T00:11:37Z

No description provided.

eth-bot · 2023-04-16T00:12:06Z

File `EIPS/eip-6884.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

github-actions · 2023-09-18T00:16:42Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions · 2023-09-18T18:53:36Z

The commit 08ee53d (as a parent of f702091) contains errors.
Please inspect the Run Summary for details.

SamWilsn · 2023-09-18T18:48:22Z

EIPS/eip-6884.md

+eip: 6884
+title: Delegatable Utility Tokens Derived from NFTs
+description: Structure and interface for Delegatable Utility Tokens (DUT) for enhancing the utility of NFTs.
+author: JB Won (@JB_theRedDuck), dagarn (@0xdagarn), Jennifer Lee (@purp-lee), Bora Lee (@Violet-Bora-Lee), Taehyeong Noh (@fin)


The first username here isn't a valid GitHub identifier.

Suggested change

author: JB Won (@JB_theRedDuck), dagarn (@0xdagarn), Jennifer Lee (@purp-lee), Bora Lee (@Violet-Bora-Lee), Taehyeong Noh (@fin)

author: JB Won, dagarn (@0xdagarn), Jennifer Lee (@purp-lee), Bora Lee (@Violet-Bora-Lee), Taehyeong Noh (@fin)

SamWilsn · 2023-09-18T18:49:18Z

EIPS/eip-6884.md

+
+The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.
+
+**Every ERC-6884 compliant contract must implement the `ERC6884` and `ERC165` interfaces**:


Suggested change

**Every ERC-6884 compliant contract must implement the `ERC6884` and `ERC165` interfaces**:

**Every ERC-6884 compliant contract must implement the `IERC6884` and `ERC165` interfaces**:

SamWilsn · 2023-09-18T18:51:01Z

EIPS/eip-6884.md

+
+**Every ERC-6884 compliant contract must implement the `ERC6884` and `ERC165` interfaces**:
+
+```solidity=


Suggested change

```solidity=

```solidity

SamWilsn · 2023-09-18T18:51:19Z

EIPS/eip-6884.md

+```solidity=
+pragma solidity ^0.8.0;
+
+interface IERC6884 /* is IERC165 */ {


Suggested change

interface IERC6884 /* is IERC165 */ {

interface IERC6884 /* is ERC165 */ {

SamWilsn · 2023-09-18T18:53:55Z

EIPS/eip-6884.md

+
+interface ERC165 {
+    /// @notice Query if a contract implements an interface
+    /// @param interfaceID The interface identifier, as specified in ERC-165
+    /// @dev Interface identification is specified in ERC-165. This function
+    ///  uses less than 30,000 gas.
+    /// @return `true` if the contract implements `interfaceID` and
+    ///  `interfaceID` is not 0xffffffff, `false` otherwise
+    function supportsInterface(bytes4 interfaceID) external view returns (bool);
+}


Suggested change

interface ERC165 {

/// @notice Query if a contract implements an interface

/// @param interfaceID The interface identifier, as specified in ERC-165

/// @dev Interface identification is specified in ERC-165. This function

/// uses less than 30,000 gas.

/// @return `true` if the contract implements `interfaceID` and

/// `interfaceID` is not 0xffffffff, `false` otherwise

function supportsInterface(bytes4 interfaceID) external view returns (bool);

}

No need to duplicate the interface here. Readers can find it in EIP-165.

SamWilsn · 2023-09-18T18:57:27Z

EIPS/eip-6884.md

+type: Standards Track
+category: ERC
+created: 2023-04-16
+---


ERC-165 is required because you use its interface, and 721 because you use its metadata.

Suggested change

---

requires: 165, 721

---

SamWilsn · 2023-09-18T18:59:14Z

EIPS/eip-6884.md

+
+## Rationale
+
+NFTs are valuable assets, and moving them can be very risky. It's also risky to try to increase their utility by locking them to a specific contract. We've come up with a simple way to enhance utility without moving NFTs.


This paragraph belongs in the Motivation section. The Rationale section should justify technical decisions made within the EIP itself, while the Motivation should justify the EIP as a whole.

SamWilsn · 2023-09-18T18:59:30Z

EIPS/eip-6884.md

+
+There might be dApps build based on supply and demand for usage rights, facilitated by this delegation process.
+
+## **Test Cases**


Suggested change

## **Test Cases**

## Test Cases

SamWilsn · 2023-09-18T18:59:39Z

EIPS/eip-6884.md

+➜ yarn hardhat test test/test.js
+```
+
+## **Reference Implementation**


Suggested change

## **Reference Implementation**

## Reference Implementation

SamWilsn · 2023-09-18T19:00:29Z

assets/eip-6884/yarn.lock

Please remove build system files.

github-actions · 2023-10-09T00:17:09Z

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

SamWilsn · 2023-10-25T22:08:07Z

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

set eip number + create draft

af48a65

blgaman requested a review from eth-bot as a code owner April 16, 2023 00:11

fix EIP number

d08f4e8

eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 16, 2023

Commit from EIP-Bot

583d0f6

eth-bot changed the base branch from master to eipbot/6884 April 16, 2023 00:12

Merge branch 'eipbot/6884' into master

497fb1b

eth-bot changed the base branch from eipbot/6884 to master April 16, 2023 00:12

github-actions bot added the w-ci Waiting on CI to pass label Apr 16, 2023

SamWilsn closed this Apr 16, 2023

SamWilsn reopened this Apr 16, 2023

blgaman added 3 commits April 26, 2023 15:19

add codes related to eip-6884

b0f9712

Merge remote-tracking branch 'origin/master'

a540799

update eip

0bcfc08

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 26, 2023

eth-bot changed the title ~~Add EIP: Extendable Utility Tokens Derived from Origin NFTs~~ Add EIP: Delegatable Utility Tokens Derived from Origin NFTs Apr 26, 2023

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 26, 2023

blgaman added 3 commits April 29, 2023 17:59

remove eip draft

c7ab8a4

use relative path

ea5dd57

conform to eip format

a432d8b

eth-bot changed the title ~~Add EIP: Delegatable Utility Tokens Derived from Origin NFTs~~ Add EIP: Delegatable Utility Tokens Derived from NFTs Apr 29, 2023

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 29, 2023

blgaman added 2 commits April 29, 2023 18:28

correct errors related to the ERC word

5e93552

use erc

08ee53d

github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 29, 2023

github-actions bot added the w-stale Waiting on activity label Sep 18, 2023

SamWilsn closed this Sep 18, 2023

SamWilsn reopened this Sep 18, 2023

SamWilsn requested changes Sep 18, 2023

View reviewed changes

github-actions bot removed the w-stale Waiting on activity label Sep 19, 2023

github-actions bot added the w-stale Waiting on activity label Oct 9, 2023

SamWilsn closed this Oct 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: Delegatable Utility Tokens Derived from NFTs #6884

Add EIP: Delegatable Utility Tokens Derived from NFTs #6884

blgaman commented Apr 16, 2023

eth-bot commented Apr 16, 2023 •

edited

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

SamWilsn Sep 18, 2023

github-actions bot commented Oct 9, 2023

SamWilsn commented Oct 25, 2023

	author: JB Won (@JB_theRedDuck), dagarn (@0xdagarn), Jennifer Lee (@purp-lee), Bora Lee (@Violet-Bora-Lee), Taehyeong Noh (@fin)
	author: JB Won, dagarn (@0xdagarn), Jennifer Lee (@purp-lee), Bora Lee (@Violet-Bora-Lee), Taehyeong Noh (@fin)


		The key words “MUST”, “MUST NOT”, “REQUIRED”, “SHALL”, “SHALL NOT”, “SHOULD”, “SHOULD NOT”, “RECOMMENDED”, “MAY”, and “OPTIONAL” in this document are to be interpreted as described in RFC 2119.

		Every ERC-6884 compliant contract must implement the `ERC6884` and `ERC165` interfaces:


		Every ERC-6884 compliant contract must implement the `ERC6884` and `ERC165` interfaces:

		```solidity=

	interface IERC6884 /* is IERC165 */ {
	interface IERC6884 /* is ERC165 */ {


		## Rationale

		NFTs are valuable assets, and moving them can be very risky. It's also risky to try to increase their utility by locking them to a specific contract. We've come up with a simple way to enhance utility without moving NFTs.


		There might be dApps build based on supply and demand for usage rights, facilitated by this delegation process.

		## Test Cases

Add EIP: Delegatable Utility Tokens Derived from NFTs #6884

Add EIP: Delegatable Utility Tokens Derived from NFTs #6884

Conversation

blgaman commented Apr 16, 2023

eth-bot commented Apr 16, 2023 • edited

File EIPS/eip-6884.md

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2023

SamWilsn commented Oct 25, 2023

eth-bot commented Apr 16, 2023 •

edited

File `EIPS/eip-6884.md`