Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: MIME Type For Web3 URL in Auto Mode #7087

Closed
wants to merge 11 commits into from

Conversation

qizhou
Copy link
Contributor

@qizhou qizhou commented May 28, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@qizhou qizhou requested a review from eth-bot as a code owner May 28, 2023 16:22
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels May 28, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 28, 2023

File EIPS/eip-7087.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Create eip-xxx.md Add EIP: MIME Type For Web3 URL in Auto Mode May 28, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels May 28, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 28, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 29, 2023
Copy link

@nand2 nand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank for writing it. I suggested some changes:

  • Added that <contentType> must follow structure of a MIME type, or an error is thrown
  • Added that <fileType> must be recognized and translatable to a MIME type, or an error is thrown.
  • Use of the word "query parameter" instead of "query", more precise

Thanks!

EIPS/eip-7087.md Outdated

The standard introduces three types of queries to determine the MIME type.

- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or
- `mime.content=<contentType>`, where `<contentType>` is a URL-encoded [MIME type](https://datatracker.ietf.org/doc/html/rfc6838). If the URL-decoded `<contentType>` does not follow the structure of a MIME type, an error is thrown. After URL decoding, `<contentType>` is set as the value of the `Content-Type` header of the response; or

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIP cannot use the external link. Going to remove the link here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do actually allow links to RFCs! See EIP-1 for details.

EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated

- `mime.content=<contentType>`, where `<contentType>`, after URL decoding, sets `Content-Type` field in the response header; or
- `mime.type=<fileType>`, where `<fileType>` is the file suffix that determines `Content-Type` field in the response header; or
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to data URL standard. If the data cannot be parsed as data URL, an error will be returned.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to data URL standard. If the data cannot be parsed as data URL, an error will be returned.
- `mime.dataurl=(true|false)`, which determines whether to decode the returned EVM data and set the MIME type according to the [data URL standard](https://datatracker.ietf.org/doc/html/rfc2397). If the data cannot be parsed as data URL, an error will be returned.

EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
EIPS/eip-7087.md Outdated Show resolved Hide resolved
qizhou and others added 2 commits May 29, 2023 08:10
Co-authored-by: nand2 <nicolas@deschildre.fr>
Co-authored-by: nand2 <nicolas@deschildre.fr>
@nand2
Copy link

nand2 commented May 29, 2023

Also I just remember we discussed the mix ?returns=&mime.xx=
If ERC-4804 returns is present, mime.xx will be always ignored : Sound good?
I think we should add this.

@github-actions
Copy link

The commit 8d9dfab (as a parent of f6c642a) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 29, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 29, 2023
EIPS/eip-7087.md Outdated Show resolved Hide resolved
Co-authored-by: nand2 <nicolas@deschildre.fr>
@nand2
Copy link

nand2 commented Sep 25, 2023

Hi! I am going to add more changes for the auto mode, please don't merge this pull request yet! Thanks.

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
nand2 added a commit to nand2/ERCs that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants