Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Interface Naming Conventions #7182

Closed
wants to merge 15 commits into from
Closed

Add EIP: Interface Naming Conventions #7182

wants to merge 15 commits into from

Conversation

pcaversaccio
Copy link
Contributor

This specification defines a standardised way of naming interface functions, event or custom error definitions, or anything else included in an interface definition that is used as an identifier by compilers in some form.

pcaversaccio and others added 11 commits January 6, 2023 14:07
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-interface t-meta labels Jun 15, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 15, 2023

File EIPS/eip-7182.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot changed the title Add EIP: Interface Naming Conventions Add EIP: Interface naming conventions Jun 15, 2023
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Jun 15, 2023
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@github-actions
Copy link

The commit 6f53822 (as a parent of 7101bf7) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 15, 2023
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 16, 2023
@pcaversaccio
Copy link
Contributor Author

quickly following up: any feedback @axic, @Pandapip1, @SamWilsn, @xinbenlv or can we get this merged since all tests pass?

@pcaversaccio pcaversaccio changed the title Add EIP: Interface naming conventions Add EIP: Interface Naming Conventions Jul 3, 2023
@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
@SamWilsn
Copy link
Contributor

@pcaversaccio Sorry it's taken so long to get someone to take a look at this! From a first pass, I would say that this isn't a good fit for an EIP. I'd probably publish this as a standalone style guide.


Unless I'm misunderstanding the point? Maybe this is supposed to be a normalization step that compilers perform before generating the ABI and hashing interface ids / function selectors? If this is something that is supposed to be shared by all compilers, (1) I think that needs to be made more clear in the proposal, and (2) wouldn't this introduce a ton of backwards compatibility issues?

@pcaversaccio pcaversaccio deleted the checksum-name branch October 26, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants