Add EIP-7514 higher-churn-limit-to-lower tests #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
reviewed
Feb 15, 2024
| assert spec.get_current_epoch(state) == fork_epoch | ||
|
|
||
| yield "blocks", [] | ||
| yield "post", state |
There was a problem hiding this comment.
The test format does not support this, see https://github.com/ethereum/consensus-specs/blob/dev/tests/formats/transition/README.md
post is "A SSZ-snappy encoded BeaconState according to the specification of the post fork, the state after running the block transitions"
Therefore, you need to add a block, as post is the last applied block's immediate post-state.
I guess the easiest fix is to add some more empty slots and then just add 1 more block to ensure that everything was processed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #3458
Description
Add fork transition test case where the churn limit was higher than
MAX_PER_EPOCH_ACTIVATION_CHURN_LIMITbut will be reduced toMAX_PER_EPOCH_ACTIVATION_CHURN_LIMITat fork boundary due toEIP-7514.