chore: Add correct type casts to eip7594 functions #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Apr 18, 2024
kevaundray
changed the title
|
The invalid base class error comes from I suspect that the issue arises because the size of the list is not a literal |
kevaundray
force-pushed
the
kw/add-eip7594-to-pylint
branch
from
6651612
to
9c9f8f1
Compare
kevaundray
commented
Apr 18, 2024
…ss Container(List[c, a*b])`
hwwhww
reviewed
Apr 19, 2024
hwwhww
reviewed
Apr 19, 2024
This was referenced Apr 22, 2024
kevaundray
changed the title
|
I've removed the check from the CI, since this PR is very prone to having merge conflicts. There seems to be an underlying issue that I've yet to investigate (CI timing out) |
asn-d6
force-pushed
the
kw/add-eip7594-to-pylint
branch
from
1cd63df
to
8ec433c
Compare
asn-d6
force-pushed
the
kw/add-eip7594-to-pylint
branch
from
8ec433c
to
6eb5756
Compare
jtraglia
pushed a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hwwhww
This PR resolves all of the errors for eip7594.
I applied a workarounf for the error
error: Invalid base class "List"-- Happy to revert if there is a better solution.