adds back to top button [Fixes #12194] #12906
Conversation
alex1092
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
the
needs review 👀
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@alex1092 Great work! Thank you! Testing this on the browser, I think the design is not right... my bad sorry Is it possible to ask you to make some changes, not to the behavior but to the position of the elements on the footer? something like this, what do you think? Doable? I change the Figma file. |
|
No problem I'll review this in the morning |
| window.scrollTo({ top: 0, behavior: "smooth" }) | ||
| } | ||
|
|
||
| export const GoToTopButton = memo(() => { |
There was a problem hiding this comment.
@alex1092 memo is not needed for this component
There was a problem hiding this comment.
Yep no worries, there had been design changes so I need to refactor this again
| ) | ||
| }) | ||
|
|
||
| GoToTopButton.displayName = "GoToTopButton" |
There was a problem hiding this comment.
displayName is not required as its set automatically in this case
|
|
||
| import { Button } from "./Buttons" | ||
|
|
||
| const scrollToTop = () => { |
There was a problem hiding this comment.
@alex1092 Note that we have a scrollIntoView.ts inside src/lib/utls which we can use here instead of making a new "scrollToTop" component. Just pass __next as the toId... that will target the root Next.js div and scroll the user to the top.
ie:
import { scrollIntoView } from "@/lib/utils/scrollIntoView"
// ...
scrollIntoView("__next")| isSecondary | ||
| onClick={scrollToTop} | ||
| > | ||
| Go to top |
There was a problem hiding this comment.
We'll want to set this up for translation as well. I'm happy to do this before this gets merged when ready.
Description
Adding a go to top button [#12194]
Changelog
GoToTopButton.tsxcomponentFooter.tsxRelated Issue
#12194
Screen shots
Screen.Recording.2024-05-06.at.1.07.14.PM.mov
Screen.Recording.2024-05-06.at.1.04.53.PM.mov