Crowdin CI v2 #12922
Crowdin CI v2 #12922
Conversation
extract env vars to single-declaration; remove sleep and replace with awaitLatestBuild script; move timing to AM,
this is updated with each import cycle and committed; large number of build minutes and not required here
github-actions
bot
added
needs review 👀
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
in lieu of incorporation into CI/CD workflow; keeps triggerBuild.ts script
Repeat calls could produce the same build ID. `import "dotenv/config"` not needed when called from an action
Requires getting process.env.BUILD_ID from previous script in workflow (triggerBuild.ts)
| OUTPUT=$(npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/triggerBuild.ts) | ||
| echo "$OUTPUT" |
There was a problem hiding this comment.
This syntax echo's the console.log statements made from inside triggerBuild.ts. Console log statements matching a particular pattern of ::set-output name=key_name::value can be extracted in a future step.
In triggerBuild.ts we're console logging ::set-output name=buildId::${id} which allows us to get the buildId variable next.
| env: | ||
| BUILD_ID: ${{ steps.build-crowdin.outputs.buildId}} |
There was a problem hiding this comment.
This assigns the buildId output from the previous step (step id: build-crowdin) to an environment variable to be accessed by the next script.
| OUTPUT=$(npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/awaitLatestBuild.ts) | ||
| echo "$OUTPUT" |
There was a problem hiding this comment.
Similar syntax to above, but this time we're outputting ::set-output name=buildSuccess::true (or false) depending if the build eventually switched to "finished" status or not.
| run: | | ||
| if [ "${{ steps.build-crowdin.outputs.buildSuccess }}" = "false" ]; then | ||
| echo "Build timed out, exiting" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
If the buildSuccess from the prior step was "false" the we exit early due to timing out. exit 1 will be treated as a failure, and the workflow will stop here.
| - name: Get latest translation bucket directory ids | ||
| run: npx ts-node -O '{"module":"commonjs"}' ./src/scripts/crowdin/translations/getBucketDirectoryIds.ts |
There was a problem hiding this comment.
Run the script to get the up-to-date bucket directory id's
There was a problem hiding this comment.
Created this since fetchAndSaveDirectories does not automatically call this function, and it is used elsewhere so I wanted to avoid conflicting.
| import "dotenv/config" | ||
|
|
There was a problem hiding this comment.
Turns out this isn't needed when running from an action
| `Build ${isAlreadyFinished ? "already finished" : "triggered"} id:`, | ||
| id | ||
| ) | ||
| console.log(`::set-output name=buildId::${id}`) |
There was a problem hiding this comment.
output id for use in next workflow step
| } | ||
|
|
||
| if (data.status !== FINISHED) { | ||
| console.error(`::set-output name=buildSuccess::false`) |
There was a problem hiding this comment.
If fetch has timed out and still not finished, export buildSuccess=false to terminate workflow early.
.github/workflows/build-crowdin.yml
Outdated
There was a problem hiding this comment.
No longer needed as a dedicated workflow.
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
|
Closing for now in lieu of #12936 |
github-actions
bot
added
the
abandoned
|
#12936 attempted to use |
wackerow
removed
the
abandoned
Description
TODO: