Investigate unused imports in tests/* #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardgreg
force-pushed
the
unused-imports
branch
from
367f326
to
18acf26
Compare
richardgreg
changed the title
|
This is a great start; thank you so much! To prevent these from creeping back in, I've re-enabled flake8 on the test folder on this branch. It'll probably find a bunch more issues. If you can fix them, we'd really appreciate it. If not, I'll be back to clean them up when I get the chance. |
|
You're welcome. I'd be happy to keep the changes coming. |
|
@SamWilsn are there any more implementations needed for this pr for it to be merged? |
SamWilsn
approved these changes
May 16, 2024
|
Tests passed locally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There are unused imports in the test folder. Refactoring needed
Related to Issue #
closes #901
How was it fixed?
Use pylint to find unused import and refactor it
Cute Animal Picture