Implement EIP-2935 #941
Merged
Implement EIP-2935 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
force-pushed
the
eips/prague/eip-2935
branch
from
0c6bb13
to
6ac9b55
Compare
Bbjj88h
approved these changes
May 2, 2024
gurukamath
force-pushed
the
eips/prague/eip-2935
branch
from
6ac9b55
to
b945b2b
Compare
|
Re-based on |
SamWilsn
reviewed
May 6, 2024
gurukamath
force-pushed
the
eips/prague/eip-2935
branch
from
b945b2b
to
e5dfbb7
Compare
SamWilsn
reviewed
May 6, 2024
gurukamath
force-pushed
the
eips/prague/eip-2935
branch
from
e5dfbb7
to
d33b1c0
Compare
petertdavies
approved these changes
May 13, 2024
| recent_block_hashes.append(most_recent_block_hash) | ||
| # At fork block, store the hashes for earlier blocks. | ||
| current_block = block | ||
| for i in range(HISTORY_SERVE_WINDOW - 1): |
There was a problem hiding this comment.
Currently old.blocks is only 256 blocks long. So this function will fail if we run the transition on a real chain.
I don't think this is a blocker for this PR, but we should open an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-2935 is not currently implemented.
Related to Issue #938
How was it fixed?
Implemented the EIP for Prague.
Cute Animal Picture