trie, eth/protocols/snap: sanitize the committed node data #29485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds one more check before committing the trie nodes from the
trie.Syncer
:The check is cheap enough and shouldn't have any performance impact.
The node blob cached in the
trie.Syncer
is not deep-copied, rather than a reference of the network packet.Theoretically it should be safe the hold the network packet reference being originated from here, although i am not 100% confident about it.
If it's possible to empties the referenced blob somehow, than it could be the root cause of #29436