all: remove unused clique logic #29710
Open
+40
−1,883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the latest release, Geth requires upon startup that the configured chain is known to be merged to PoS. This means that clique blocks can no longer be created.
This PR removes the associated code, and the
Cliqueconsensus object only retains logic to:Test cases which cover the import of a chain that has been merged part-way through depend on some of the removed logic to produce a test-chain with clique blocks in the pre-merge portion. Right now, I just yolo-remove those but it's probably worth isolating any required clique-logic for those somewhere internally.