feat: support disc v4/v5 mix mode in bootnode #29717
Open
+48
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool very cool
…On Mon, May 6, 2024, 5:05 PM 2129zxl ***@***.***> wrote:
*Description*
The p2p module in op-geth has already implemented sharedUdp to enable
coexistence of node discovery protocols for both v4 and v5. However, node
discovery in the bootnode currently supports only a single protocol. This
PR has achieved a mix of v4 and v5 protocols for the bootnode, allowing it
to provide node discovery functionality to geth nodes running different
versions simultaneously.
*Tests*
3 scenarios has been tested:
v4=true and v5=false, it only supported discv4
v5=true and v4=false, it only supported discv5 (defalut config)
v5=true and v4=true, it supported both discv5 and discv4
*Additional context*
A new configuration option --v4 has been added. The configuration method
is similar to that of geth. When both are set to true, both protocols are
supported simultaneously. The default values are --v5=true --v4=false,
meaning only the v5 protocol is supported by default.
------------------------------
You can view, comment on, or merge this pull request online at:
#29717
Commit Summary
- a48ee55
<a48ee55>
feat: support disc v4/v5 mix mode in bootnode
File Changes
(2 files <https://github.com/ethereum/go-ethereum/pull/29717/files>)
- *M* cmd/bootnode/main.go
<https://github.com/ethereum/go-ethereum/pull/29717/files#diff-fb8cc298aa48a0d6a6ce05b44dd3ef0ddfe61a5fac0e765031fbf289dd1698bf>
(47)
- *M* p2p/server.go
<https://github.com/ethereum/go-ethereum/pull/29717/files#diff-490d9ce631d76703e922d7cb73d771c32d9f632729ea464f9080f54d6035dda5>
(10)
Patch Links:
- https://github.com/ethereum/go-ethereum/pull/29717.patch
- https://github.com/ethereum/go-ethereum/pull/29717.diff
—
Reply to this email directly, view it on GitHub
<#29717>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE4O6K2AUMUD52DSQP2ZIULZBALE5AVCNFSM6AAAAABHJ6E4LSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DCOJYGE2DMMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The p2p module in geth has already implemented sharedUdp to enable coexistence of node discovery protocols for both v4 and v5. However, node discovery in the bootnode currently supports only a single protocol. This PR has achieved a mix of v4 and v5 protocols for the bootnode, allowing it to provide node discovery functionality to geth nodes running different versions simultaneously.
Tests
3 scenarios has been tested:
v4=true and v5=false, it only supported discv4
v5=true and v4=false, it only supported discv5 (defalut config)
v5=true and v4=true, it supported both discv5 and discv4
Additional context
A new configuration option
--v4has been added. The configuration method is similar to that of geth. When both are set to true, both protocols are supported simultaneously. The default values are--v5=true--v4=false, meaning only the v5 protocol is supported by default.