eth/protocols/snap: save nodes on right boundary in hash mode #29791
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It panics, need investigation |
holiman
reviewed
Jun 4, 2024
| @@ -280,8 +280,9 @@ func (t *hashTrie) update(key, value []byte) error { | |||
|
|
|||
| // commit implements genTrie interface, committing the nodes on right boundary. | |||
| func (t *hashTrie) commit(complete bool) common.Hash { | |||
| hash := t.tr.Hash() // flush the nodes on right boundary | |||
There was a problem hiding this comment.
For the stacktrie, this will forcibly "The main purpose here is to commit the nodes on right boundary", and this make it so that it's not possible to add more data to this stacktrie. (because there will be no nodes to insert into, only one hashed rootnodes).
However, this method is used in places where there's more data to come, e..g
} else if task.genBatch.ValueSize() > batchSizeThreshold {
task.genTrie.commit(false)A "time to push to disk for now" invocation^
There are two concerns, but only one flag
- Caller wants to commit to release a bit of memory,
- Caller wants to force-commit to flush right-hand boundary
The stacktrie doesn't really need "commit to release some memory", since it does so continuously. Perhaps we need two flags
Anyway, that's the cause for the panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in hash gentrie.
In hash-mode, no matter the gentrie is complete or not, all the nodes on the right boundary should be flushed into disk if
commitis called. As the garbage nodes will be unlinked from the trie by state healer.Currently, if the right boundary of gentrie is claimed as incomplete, nodes on it are silently discarded. Given that the nodes on incomplete boundary are usually useless, but still the behavior should be aligned in hash gentrie.