Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit of Update run.md #3202

Merged
merged 3 commits into from
May 21, 2024
Merged

Edit of Update run.md #3202

merged 3 commits into from
May 21, 2024

Conversation

vermouth22
Copy link
Collaborator

Edits to run.md

Edits to run.md
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AtAddress is not AtAddress. The button is called AtAddress - nowhere else is it At Address. We could consider renaming the button - but not to At Address. It should be a single word. But I think we should leave the naming discussion for another time (delay it) and bring it up out side of this PR.

@vermouth22
Copy link
Collaborator Author

AtAddress is not AtAddress. The button is called AtAddress - nowhere else is it At Address. We could consider renaming the button - but not to At Address. It should be a single word. But I think we should leave the naming discussion for another time (delay it) and bring it up out side of this PR.

Agreed. It should be "AtAddress" everywhere... including on the button

Copy link
Collaborator Author

@vermouth22 vermouth22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now edited

@ryestew ryestew merged commit 2acc2d7 into pin1 May 21, 2024
1 check passed
@ryestew ryestew deleted the vermouth22-patch-2 branch May 21, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants