Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --metadata flag #709

Open
bguiz opened this issue Oct 11, 2023 · 4 comments
Open

Support for --metadata flag #709

bguiz opened this issue Oct 11, 2023 · 4 comments

Comments

@bguiz
Copy link

bguiz commented Oct 11, 2023

$ solcjs --bin --abi --metadata ./account.sol
error: unknown option '--metadata'
  • I would like to have this available in solcjs as well, in order to be able to use it with smart contract verification tools, such as sourcify
@mehtavishwa30
Copy link

Hey @bguiz! Thanks for bringing this up.

Would love to understand the purpose or motivation behind using the solcjs wrapper script rather than native solc binary which provides all the options that you may required and aren't intended to make it in the wrapper script.

Please note that if you require options that aren't available in the wrapper script, we recommend you to use the native solc binary.

@bguiz
Copy link
Author

bguiz commented Apr 18, 2024

@mehtavishwa30 (1) when using a build tool or framework that already has solcjs baked in. e.g. hardhat, remix, sourcify, etc. (2) for developers who are trialling or building POCs, and aren't that invested, npm i is easier than installing the solc binary.

Would love to understand the purpose or motivation behind using the solcjs wrapper script rather than native solc binary which provides all the options that you may required and aren't intended to make it in the wrapper script.

@nikola-matic
Copy link
Contributor

@mehtavishwa30 (1) when using a build tool or framework that already has solcjs baked in. e.g. hardhat, remix, sourcify, etc. (2) for developers who are trialling or building POCs, and aren't that invested, npm i is easier than installing the solc binary.

Would love to understand the purpose or motivation behind using the solcjs wrapper script rather than native solc binary which provides all the options that you may required and aren't intended to make it in the wrapper script.

solcjs provides full access to the standard JSON interface, which means you can get metadata access via that, so I'm curious as to why you haven't gone for that approach?

@bguiz
Copy link
Author

bguiz commented Apr 19, 2024

@nikola-matic this is great!

solcjs provides full access to the standard JSON interface,

it sounds like it should then be easier to implement the --metadata in the wrapper!

error: unknown option '--metadata'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants