Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force tape version to 4.9.2. #339

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Force tape version to 4.9.2. #339

merged 1 commit into from
Feb 11, 2019

Conversation

chriseth
Copy link
Contributor

A new tape version was released two days ago which makes our test setup fail. I'm still not sure whether it is a bug with our tests or with tape, but this should get us through the release tomorrow.

I'm suspecting this PR being the cause of it.

Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create an issue for looking into this again? I can imagine this will fall us into the back sooner or later otherwise and we should be forward-compatible - but I'm fine with this for the upcoming release.

@chriseth
Copy link
Contributor Author

Created: ethereum/solidity#5963

@chriseth chriseth merged commit 1dcd861 into master Feb 11, 2019
@ekpyron ekpyron deleted the fixTape branch February 11, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants