Initial bits for integrating the LSP API. #609

christianparpart · 2022-02-21T13:50:50Z

No description provided.

coveralls · 2022-02-21T14:26:29Z

Coverage decreased (-3.06%) to 80.526% when pulling a21be10 on lsp-integration into f853458 on master.

wrapper.ts

chriseth · 2022-02-22T09:26:20Z

Looks good in general! Maybe we can actually just ignore the synchronous read problem for the first version.
Did you try building a vscode plugin on top of this?

Also @axic had some additional ideas for unifying the callback functions.

wrapper.ts

README.md

wrapper.ts

stephensli

Legacy Coding Style

All changes show entirely legacy coding style for Javascript and goes against best practices. Additionally the code is made increasingly more complicated than required with multiple nested functions which should not be const functions but well defined for typing.

Interfaces should be moved outside of wrapper.ts file.
no supporting tests for changes.
no linting

Just my two cents.

stephensli · 2022-03-14T15:53:20Z

wrapper.ts

@@ -79,6 +79,8 @@ function setupMethods (soljson) {
      const copyFromCString = soljson.UTF8ToString || soljson.Pointer_stringify;

      const wrappedReadCallback = function (path: string, contents: string, error: string) {


just run npm run lint:fix or the related package.json command to resolve these before committing.

christianparpart force-pushed the lsp-integration branch from 9e4af31 to e6942a8 Compare February 21, 2022 13:51

christianparpart force-pushed the lsp-integration branch 5 times, most recently from 1c76e96 to d66dd93 Compare February 21, 2022 15:19

chriseth reviewed Feb 22, 2022

View reviewed changes

wrapper.ts Outdated Show resolved Hide resolved