Update bytecode size test for byzantium. #15100
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
approved these changes
May 14, 2024
There was a problem hiding this comment.
Looks like one annoying consequence of moving old EVM runs to nightly is that it's easy to forget to update their expectations. CI won't detect it until the next night.
BTW, the failure in c_ext_benchmarks is probably because the run on the commit it's based on failed (or was interrupted and did not finish).
Closed
We should probably consider removing test cases for which this will likely happen (less testing is a reasonable effect of these evm versions being deprecated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the nightly CI failure.
https://circleci.com/gh/ethereum/solidity/1542038
Depends on the deprecated EVM version test run passing in #15101