Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install cvc5 in buildpack-deps #15102

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Install cvc5 in buildpack-deps #15102

wants to merge 4 commits into from

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented May 14, 2024 •
edited

This PR is a draft until #15078 is complete. They need to be merged together since we are replacing cvc4.

@r0qs r0qs force-pushed the install-cvc5 branch 3 times, most recently from 18da83e to a2bcce1 Compare May 15, 2024 14:08
@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204-9 [solbuildpackpusher/solidity-buildpack-deps@sha256:80247de9655b1f39afd4ac22b14266bc9b9a0d64b283ae8fb9cb5b8250e4e77d].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2204.clang-8 [solbuildpackpusher/solidity-buildpack-deps@sha256:2662376fe0e1ec2d346495a19a6d64508c1048d5a7325d8600c33c343fa64a0f].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:emscripten-18 [solbuildpackpusher/solidity-buildpack-deps@sha256:a76706b791849199f9906023d5d44878d5d19195f6fb959d7cd505a0be2cbee4].

@github-actions GitHub Actions
Copy link

solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-24 [solbuildpackpusher/solidity-buildpack-deps@sha256:b8b645fa7ab40d55f2d16eac295d16ca01ec51d32be7d668ae6eaecd47dbd763].

@r0qs r0qs force-pushed the install-cvc5 branch 2 times, most recently from ad0cdfc to 617fe00 Compare May 16, 2024 14:57
@r0qs r0qs mentioned this pull request Jun 6, 2024
Open
@r0qs r0qs marked this pull request as ready for review June 6, 2024 16:23
nikola-matic
nikola-matic approved these changes Jun 6, 2024
View reviewed changes
scripts/docker/buildpack-deps/Dockerfile.ubuntu2004
@@ -59,18 +59,32 @@ RUN set -ex; \
tabulate \
z3-solver;

# TODO: we could eliminate duplication by using a Dockerfile extension like:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving validate_checksum to a common script would also be nice :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'm not sure if we should address this in the current PR. I just realized I should have removed this TODO. I originally included it to remind myself of alternatives while the PR was still a draft. Should I remove it now and create an issue instead, so we can refactor it later?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, this is definitely not for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-matic nikola-matic nikola-matic approved these changes

Assignees
No one assigned
Labels
build system 🏗️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r0qs @nikola-matic