Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using namespace std from testing tools, ossfuzz and yulPhaser #15110

Merged

Conversation

hydai
Copy link
Contributor

@hydai hydai commented May 15, 2024

In this PR, I removed some of the using namespace std statements mentioned in #14403

  • test/tools
  • test/tools/ossfuzz
  • tools/yulPhaser

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@hydai hydai force-pushed the hydai/not_use_using_namespace_std branch 6 times, most recently from b11907a to 1962142 Compare May 15, 2024 19:57
@cameel cameel requested a review from nikola-matic May 16, 2024 11:33
@cameel cameel changed the title Remove using namespace std Remove using namespace std from testing tools, part of ossfuzz and yulPhaser May 16, 2024
Copy link
Collaborator

@nikola-matic nikola-matic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hydai, thanks for this! The changes look good, however, you're missing a change to confirm that using namespace std was properly removed in scripts/check_style.

You'll need to add the following directories to the list:

test/tools/*
test/tools/ossfuzz/*
test/tools/ossfuzz/protomutators/*
tools/yulPhaser/*

Please add them and squash the commits into one, and we should be good to merge.

@hydai hydai force-pushed the hydai/not_use_using_namespace_std branch from 1962142 to 1c6d135 Compare May 16, 2024 14:06
@hydai hydai changed the title Remove using namespace std from testing tools, part of ossfuzz and yulPhaser Remove using namespace std from testing tools, ossfuzz and yulPhaser May 16, 2024
@hydai hydai force-pushed the hydai/not_use_using_namespace_std branch from 1c6d135 to b9ad737 Compare May 16, 2024 14:07
@hydai
Copy link
Contributor Author

hydai commented May 16, 2024

Hi @nikola-matic, I just added those folders into the scripts/check_style. Also, I modified the remaining files, so I changed the title to testing tools, ossfuzz and yulPhaser.

@hydai hydai force-pushed the hydai/not_use_using_namespace_std branch 5 times, most recently from 1e84797 to 26929bb Compare May 16, 2024 16:18
@hydai hydai force-pushed the hydai/not_use_using_namespace_std branch from 26929bb to 24f18e8 Compare May 16, 2024 16:36
@nikola-matic nikola-matic merged commit de00244 into ethereum:develop May 16, 2024
72 checks passed
@hydai hydai deleted the hydai/not_use_using_namespace_std branch May 16, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants