New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate functional-red-black-tree to js-sdsl #2283
Comments
Thanks for the note. We're definitely open to a PR though will want to see the benchmarks using our own code before merging. Note, this dependency is also used in our |
OK, I'll show you the benchmark result later. |
I submitted a PR: #2285. And benchmarks here:
https://github.com/ZLY201/ethereumjs-monorepo/actions/runs/3054050866/jobs/4925454999 > @ethereumjs/vm@6.0.0 benchmarks
> node --max-old-space-size=4096 ./benchmarks/run.js benchmarks mainnetBlocks:10
Benchmarking started...
Running 'mainnetBlocks':
Total number of blocks in data set: 15
Number of blocks to sample: 10
Block 9422905 x 18,375 ops/sec ±2.02% (82 runs sampled)
Block 9422906 x 17,719 ops/sec ±4.70% (82 runs sampled)
Block 9422907 x 17,477 ops/sec ±4.75% (85 runs sampled)
Block 9422908 x 16,721 ops/sec ±9.67% (85 runs sampled)
Block 9422910 x 17,523 ops/sec ±1.95% (80 runs sampled)
Benchmark run finished.
https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/2957405169/jobs/4729608826 > @ethereumjs/vm@6.0.0-rc.1 benchmarks
> node --max-old-space-size=4096 ./benchmarks/run.js benchmarks mainnetBlocks:10
Benchmarking started...
Running 'mainnetBlocks':
Total number of blocks in data set: 15
Number of blocks to sample: 10
Block 9422905 x 15,604 ops/sec ±3.03% (82 runs sampled)
Block 9422906 x 14,920 ops/sec ±5.10% (80 runs sampled)
Block 9422907 x 15,375 ops/sec ±2.51% (82 runs sampled)
Block 9422908 x 14,200 ops/sec ±8.53% (71 runs sampled)
Block 9422910 x 15,627 ops/sec ±2.29% (80 runs sampled)
Benchmark run finished. |
@ZLY201 Hey there, thanks a lot for this PR, the benchmark results look really amazing 🎉, generally your whole data structure library makes a really good impression, congrats on that! 👍 |
Closed by #2285 There will be a couple of weeks until a new release on this. |
Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/
Now, we published the version 4.1.4.
I see you are using functional-red-black-tree.
In benchmark, we have confirmed that Js-sdsl is several times faster than functional-red-black-tree.
I've submitted a PR to eslint and has been accepted.
See eslint/eslint#16255 and eslint/eslint#16267.
I am willing to submit a pull request for this change.
Looking forward to your reply! :D
The text was updated successfully, but these errors were encountered: