perf: migrate rbtree to js-sdsl #2285
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Hmm, have looked at the local code changes, all looks reasonable.
Also the broader VM test suite is passing with this, so this is a strong indicator that things are working as expected since StateManager is really used heavily in there.
So: think we can merge. 😄
Again, thanks a lot, great PR! 🙏
|
|
||
| import type { Address } from '@ethereumjs/util' | ||
|
|
||
| const Tree = require('functional-red-black-tree') | ||
| // eslint-disable-next-line implicit-dependencies/no-implicit |
There was a problem hiding this comment.
Hmm, these shouldn't be necessary I guess, maybe you've forgotten to rebuild or to restart your editor or something? 🤔
Anyhow: won't trigger a new CI run just for that, have added to our #2105 issue for small fixes.
| @@ -69,7 +69,6 @@ | |||
| "async-eventemitter": "^0.2.4", | |||
| "debug": "^4.3.3", | |||
| "ethereum-cryptography": "^1.1.2", | |||
| "functional-red-black-tree": "^1.0.1", | |||
There was a problem hiding this comment.
Oh. Seems this was simply forgotten after the state manager extraction work. 🙂
Good catch! 👍
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 EthereumJS Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
Linked issue: #2283.