tx: remove isTruthy and isFalsy #2250
Conversation
gabrocheleau
requested review from
faustbrian,
jochem-brouwer,
acolytec3 and
holgerd77
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -26,7 +26,7 @@ import type { RpcTx } from '../types' | |||
| import type { Block } from '@ethereumjs/block' | |||
| import type { Log } from '@ethereumjs/evm' | |||
| import type { Proof } from '@ethereumjs/statemanager' | |||
| import type { FeeMarketEIP1559Transaction, JsonTx, TypedTransaction } from '@ethereumjs/tx' | |||
| import type { FeeMarketEIP1559Transaction, JsonRpcTx, TypedTransaction } from '@ethereumjs/tx' | |||
There was a problem hiding this comment.
This is a file in client, I think this is the wrong PR?
There was a problem hiding this comment.
Ah OK I see that the interface is moved into tx.
| import * as minimist from 'minimist' | ||
|
|
||
| const argv = minimist(process.argv.slice(2)) | ||
|
|
||
| if (isTruthy(argv.b)) { | ||
| if (argv.b === true) { |
There was a problem hiding this comment.
I'm good with this but just want to confirm, we're not looking to enforce a hard rule on how we write boolean checks where the value we're checking is indeed a boolean like here, right? So stylistically for us, it's fine to write either:
if (argv.b) or if (argv.b === true) right? Or does this eslint rule disallow the first?
There was a problem hiding this comment.
You are correct! In this case, since argv.b, is not typed, I made it explicit, but in normal cases where we're dealing with a boolean, there's no need to be explicit. Explicitness is only needed when truthiness/falsiness is involved (and boolean is true/false, not "truthy/falsy").
There was a problem hiding this comment.
Ah, that's good to have this confirmed! 🙂
Extracts the tx package from #2233