Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statemanager: remove eslint-disable from imports #2289

Merged
merged 1 commit into from Sep 16, 2022
Merged

statemanager: remove eslint-disable from imports #2289

merged 1 commit into from Sep 16, 2022

Conversation

ScottyPoi
Copy link
Contributor

Fixes tiny issue from #2105

Removing the eslint-disable comments had no effect as expected.

@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited

Codecov Report

Merging #2289 (f4022df) into master (3f7594a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 92.82% <ø> (ø)
blockchain 88.47% <ø> (ø)
client 86.95% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.56% <ø> (+0.16%) ⬆️
ethash ∅ <ø> (∅)
evm 79.23% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 88.43% <ø> (-0.03%) ⬇️
trie 90.02% <ø> (-0.35%) ⬇️
tx 97.98% <ø> (ø)
util 91.67% <ø> (ø)
vm 85.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ScottyPoi! 👍 🙂

@holgerd77 holgerd77 merged commit 0f57ec0 into master Sep 16, 2022
@holgerd77 holgerd77 deleted the remove-eslint-disable branch September 16, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: statemanager PR state: needs review type: meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ScottyPoi @holgerd77