genesis: fix holesky genesis state #3074
Merged
+163
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
force-pushed
the
fix-holesky-gensis
branch
from
3d7e1c2 to
32bab89
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as also noted by a discord user (Sea Monkey) , the client wasn't working on
--network holeskywith state trie error of not finding stateroot on execution of block 1.on debugging realized that the genesis state and the expected stateroot doesn't match, on further inspecton and debugging saw beacon contract was missing from genesis.
this PR adds the same as well as modify genesis spec to test expected stateroots of all known networks
tested with lodestar for holesky, seems to sync blocks now