Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frecency: Boost interactive selection frecency #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

euank
Copy link
Owner

@euank euank commented Jan 5, 2019

This gives a 3x weighted boost to the result of an interactive selection
on the assumption that if the user went out of their way to do an
interactive selection to choose something it's something they wish to
visit more often.

This does the necessary plumbing to implement the feature, and
implements it.

Thank you @lclarkmichalek for the idea!

Copy link
Collaborator

@LinuxMercedes LinuxMercedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

(I see you sneaking in that nifty refactor of intercept_ctrl_c!)

@euank
Copy link
Owner Author

euank commented Jan 12, 2019

I should have commented, but I'm leaving this unmerged pending one integ test.

And for that integ test, we need to support z -i in the test harness, so it's a bit of a refactor. I'm taking a stab at it now, but I don't know if I'll finish it in the chunk of time I've got for it right now.

This gives a 3x weighted boost to the result of an interactive selection
on the assumption that if the user went out of their way to do an
interactive selection to choose something it's something they wish to
visit more often.

This does the necessary plumbing to implement the feature, and
implements it.
This adds the needed testing apparatus for asserting the output of z -i
and hopefully lays the groundwork for more tests of the like.

It also adds an 'interactive list' test to start things off.
euank added 3 commits May 2, 2020 01:20
I wrote tests for it, they didn't work, and I realized that's because I
reworked main such that the jump code that's actually in use is
elsewhere. So yeah, the tests caught that, woo!
@euank
Copy link
Owner Author

euank commented May 2, 2020

It has been over a year, and I have come back to this!
I've gotten a test that works.. And actually, happily, it also caught a bug in the implementation (in that it needed to be updated for where the new jump code ended up), so it's a good sign the test works :)

@euank
Copy link
Owner Author

euank commented May 3, 2020

Self-reviewed; this still looks good.

bors r+

bors bot added a commit that referenced this pull request May 3, 2020
114:  frecency: Boost interactive selection frecency r=euank a=euank

This gives a 3x weighted boost to the result of an interactive selection
on the assumption that if the user went out of their way to do an
interactive selection to choose something it's something they wish to
visit more often.

This does the necessary plumbing to implement the feature, and
implements it.

Thank you @lclarkmichalek for the idea!

Co-authored-by: Euan Kemp <euank@euank.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build failed:

@euank
Copy link
Owner Author

euank commented May 3, 2020

Hm. Looks like one of the new tests flakes on travis-ci sometimes (hangs); it doesn't trivially reproduce locally, so I'll have to dig into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants