Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16+, CommonJS -> ESM #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Node 16+, CommonJS -> ESM #97

wants to merge 3 commits into from

Conversation

derhuerst
Copy link
Collaborator

No description provided.

@piranna
Copy link

piranna commented Sep 9, 2022

When could this be merged?

@derhuerst
Copy link
Collaborator Author

When could this be merged?

It can be merged any time. As this is a breaking change, I was hesitant to merge it just because. It seems like, with #113, we're going to have another breaking change, so it would make sense to merge & publish both at once.

@piranna
Copy link

piranna commented Sep 12, 2022

it would make sense to merge & publish both at once.

I think so :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants