Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Move canvas to development dependencies #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyranet
Copy link

@kyranet kyranet commented Feb 26, 2019

More information about devDependencies here.

The reason for this change is that gifencoder does not seem to need the package canvas to work as shown in the addFrame lines, but rather checks for the existence of the method. However, I do not find any require('canvas') in the project (unless I'm missing something!) besides the example files and tests.

@kyranet kyranet changed the title deps: Move canvas to optional dependencies deps: Move canvas to development dependencies Feb 26, 2019
@relsqui
Copy link

relsqui commented Aug 20, 2019

I'd love it if this got merged, it's currently blocking me upgrading to 2.0.0 because I don't want to debug canvas's install failures in CI given that I don't actually need canvas. :)

@cenfun
Copy link

cenfun commented Aug 24, 2019

this is great, since "canvas" module was so big (65.74 MB) and it's not runtime dependency

@lostfictions
Copy link

would love for this to get merged!

@kyranet
Copy link
Author

kyranet commented Aug 4, 2022

I really didn't want to come down to this, as I'm very against promoting my own code in similar packages, but since there's virtually no update in this repository, and this could help a lot of people, I have made a fork and is available at @skyra/gifenc.

I have rewritten the entire package to TypeScript (types are shipped in the package, no need for @types/), removed several global variables, improved performance across the board (2x speedup), all while keeping nearly 1:1 functionality and behaviour, it should be a drop-in replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants