Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment in example about quality #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

potmo
Copy link

@potmo potmo commented Jan 26, 2021

I opted to just add a small comment in the example so that those that search can find it.

I opted to just add a small comment in the example so that those that search can find it.
@skeddles
Copy link

skeddles commented Sep 6, 2021

no reason this shouldn't be accepted, so dumb that this isn't explained anywhere, unless you dig through the source:

/*
Sets quality of color quantization (conversion of images to the maximum 256
colors allowed by the GIF specification). Lower values (minimum = 1)
produce better colors, but slow processing significantly. 10 is the
default, and produces good color mapping at reasonable speeds. Values
greater than 20 do not yield significant improvements in speed.
*/

although it's still not exactly clear how it's applying this quality. a value of 1 still seems to produce a few inaccurate colors sometimes.

@JoshuaPerk
Copy link

This should be accepted.

@potmo
Copy link
Author

potmo commented Dec 12, 2021

Its soon a year since I made this patch. What's taking so long?

@skeddles
Copy link

@eugeneware

@potmo
Copy link
Author

potmo commented Jul 7, 2023

2 years. Should i close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants