Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow native coroutines to be test functions #14

Merged
merged 2 commits into from
Feb 22, 2016

Conversation

etataurov
Copy link
Contributor

This will allow to write tests using new async def/await syntax.

References:

@etataurov
Copy link
Contributor Author

Seems I forgot to check older tornado versions,
also I need to fix travis.yml to not to run old pytest&tornado under python3.5

@etataurov
Copy link
Contributor Author

Build failed again.
For 2 reasons:

  1. I forgot to exclude old pytest for python3.5
  2. Newly added test for run_sync=False uncovered that this option doesn't work with tornado=3.2. This needs to be fixed somehow: real fix, drop tornado3 support or mark this feature as tornado4 only

This will allow to write tests using new async def/await syntax.
with own implementation of with_timeout
@etataurov
Copy link
Contributor Author

@eugeniy please take a look

eugeniy added a commit that referenced this pull request Feb 22, 2016
Allow native coroutines to be test functions
@eugeniy eugeniy merged commit a01cfb1 into eugeniy:master Feb 22, 2016
@eugeniy
Copy link
Owner

eugeniy commented Feb 22, 2016

Looks good, thanks!

@vidartf vidartf mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants