-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: optimize Nuxt build config and Bootstrap Vue plugin registration #1227
Merged
LeoniePeters
merged 10 commits into
master
from
chore/optimize-nuxt-build-config-and-bootstrap-vue-plugin-registration
Sep 30, 2021
Merged
chore: optimize Nuxt build config and Bootstrap Vue plugin registration #1227
LeoniePeters
merged 10 commits into
master
from
chore/optimize-nuxt-build-config-and-bootstrap-vue-plugin-registration
Sep 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
& Bootstrap Vue plugin registration
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
Kudos, SonarCloud Quality Gate passed!
|
LeoniePeters
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimisations to Nuxt config:
Enable extractCSS to prevent inlining CSS in HTML, reducing the size of the initial document transfer (by 57 kB/45% on the homepage), but increasing the number of network requests required. Lighthouse performance reports favour extracted CSS.Disabled as it messes up some CSS. See: CSS Order is different when extractCSS is used nuxt/nuxt#4219This combination of optimisations has been tested with Lighthouse on the homepage, an item page, the collections hub page and the blog hub page, and result in performance score increases on all of 10-20 points (out of 100).
FIXME: there is one issue arising out of these changes, with the tooltips indicating metadata origin on the item page. When running in dev mode, these do not render properly at first, but making a change, any change, tosrc/components/items/SummaryInfo.vue
, causing the hot reload, gets them rendering properly. This is not however an issue on production builds.