Add E2E tests using Cypress.io #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonic
reviewed
Jan 15, 2018
| * `startSeeded` is a custom command that starts the app with seed data. | ||
| * Check out the source in ../support/commands.js | ||
| */ | ||
| cy.startSeeded() |
There was a problem hiding this comment.
is cy a "Global" that gets "injected" by the Cypress test runner?
There was a problem hiding this comment.
Yup! Cypress exposes the cy and Cypress objects as globals in your tests.
|
As a representative of the Cypress.io team, I would love to see this merged in. We stand behind our OSS test runner and believe Elm community would benefit greatly from catching errors that can only be found when testing the entire application: misconfiguration, deployment errors, missing libraries, etc. Especially since @rtfeldman got a Cypress 👕... there are no blockers 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress.io is an e2e testing tool that will be open sourced soon. I think the Elm community could benefit from such a tool and thought this would be a good place to make that introduction.
I took the liberty of writing some tests for this, just to show how straight-forward writing e2e tests is with Cypress.
Aside from adding some files, these tests don't require any other changes to this project. All the existing code and structure remains the same and the tests can be run with the standalone Cypress GUI. This avoids the need for any node modules or for a server component to be built-in to the project.
Cypress tests are readable and the docs are solid. The tests run very quickly and can be run during development, so once the Elm compiler is happy with the code, you can quickly verify that the full user experience is working as intended.