Update Kotlin to 1.9.21 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eygraber
commented
Nov 23, 2023
Comment on lines
-17
to
+28
| for (target in nativeTargets) { | ||
| targets.add(presets.getByName(target).createTarget(target)) | ||
| } | ||
| linuxX64() | ||
| macosX64() | ||
| macosArm64() | ||
| iosArm64() | ||
| iosX64() | ||
| iosSimulatorArm64() | ||
| tvosArm64() | ||
| tvosX64() | ||
| tvosSimulatorArm64() | ||
| watchosArm32() | ||
| watchosArm64() | ||
| watchosX64() | ||
| watchosSimulatorArm64() |
There was a problem hiding this comment.
preset APIs were deprecated.
eygraber
commented
Nov 23, 2023
Comment on lines
-23
to
-24
| @OptIn(ExperimentalKotlinGradlePluginApi::class) | ||
| targetHierarchy.default() |
There was a problem hiding this comment.
This is now the default and doesn't need to be explicitly called
eygraber
commented
Nov 23, 2023
| import kotlinx.atomicfu.locks.ReentrantLock | ||
| import kotlinx.atomicfu.locks.withLock | ||
|
|
||
| @SharedImmutable |
There was a problem hiding this comment.
Deprecated, message says that it doesn't actually do anything
Merged
Yeah looks like the tests are failing because of this so think we'll have to wait |
eygraber
force-pushed
the
update-kotlin
branch
from
b590c56
to
d6911a7
Compare
eygraber
force-pushed
the
update-kotlin
branch
from
d6911a7
to
6edf4b3
Compare
eygraber
force-pushed
the
update-kotlin
branch
from
6edf4b3
to
b349b9d
Compare
|
Updated |
evant
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.