Skip to content

Commit

Permalink
Demonstrate inability to tree shake any modules that
Browse files Browse the repository at this point in the history
are resolved by a plugin.
  • Loading branch information
Chris Casola committed May 25, 2021
1 parent 5a2d33f commit 2e013f4
Show file tree
Hide file tree
Showing 2 changed files with 110 additions and 0 deletions.
78 changes: 78 additions & 0 deletions internal/bundler/bundler_dce_test.go
@@ -1,9 +1,13 @@
package bundler

import (
"path/filepath"
"regexp"
"strings"
"testing"

"github.com/evanw/esbuild/internal/config"
"github.com/evanw/esbuild/internal/logger"
)

var dce_suite = suite{
Expand Down Expand Up @@ -1655,3 +1659,77 @@ func TestTreeShakingInESMWrapper(t *testing.T) {
},
})
}

func TestPackageJsonSideEffectsFalsePluginResolver(t *testing.T) {
pk2Index := `
export {default as Cmp1} from './cmp1.vue';
export {default as Cmp2} from './cmp2';
`

testPackageJsonSideEffectsFalsePluginResolver(t, pk2Index)
}

func TestPackageJsonSideEffectsFalseNoPlugins(t *testing.T) {
pk2Index := `
export {default as Cmp1} from './cmp1';
export {default as Cmp2} from './cmp2';
`

testPackageJsonSideEffectsFalsePluginResolver(t, pk2Index)
}

func testPackageJsonSideEffectsFalsePluginResolver(t *testing.T, pkg2Index string) {
t.Helper()

mockFiles := map[string]string{
"/Users/user/project/src/entry.js": `
import {Cmp2} from "demo-pkg2"
console.log(Cmp2);
`,
"/Users/user/project/node_modules/demo-pkg2/cmp1.js": `
import {__decorate} from './helper';
let Something = {}
__decorate(Something);
export default Something;
`,
"/Users/user/project/node_modules/demo-pkg2/cmp2.js": `
import {__decorate} from './helper';
class Something {}
__decorate(Something);
export default Something;
`,
"/Users/user/project/node_modules/demo-pkg2/helper.js": `
export function __decorate(s) {
}
`,
"/Users/user/project/node_modules/demo-pkg2/package.json": `
{
"sideEffects": false
}
`,
"/Users/user/project/node_modules/demo-pkg2/index.js": pkg2Index,
}

dce_suite.expectBundled(t, bundled{
files: mockFiles,
entryPaths: []string{"/Users/user/project/src/entry.js"},
options: config.Options{
Mode: config.ModeBundle,
AbsOutputFile: "/out.js",
Plugins: []config.Plugin{
{
OnResolve: []config.OnResolve{
{
Filter: regexp.MustCompile("\\.vue$"),
Callback: func(ora config.OnResolveArgs) config.OnResolveResult {
return config.OnResolveResult{
Path: logger.Path{Text: filepath.Join(ora.ResolveDir, strings.Replace(ora.Path, ".vue", ".js", 1))},
}
},
},
},
},
},
},
})
}
32 changes: 32 additions & 0 deletions internal/bundler/snapshots/snapshots_dce.txt
Expand Up @@ -414,6 +414,22 @@ console.log("hello");
// Users/user/project/src/entry.js
console.log(demo_pkg_exports);

================================================================================
TestPackageJsonSideEffectsFalseNoPlugins
---------- /out.js ----------
// Users/user/project/node_modules/demo-pkg2/helper.js
function __decorate(s) {
}

// Users/user/project/node_modules/demo-pkg2/cmp2.js
var Something = class {
};
__decorate(Something);
var cmp2_default = Something;

// Users/user/project/src/entry.js
console.log(cmp2_default);

================================================================================
TestPackageJsonSideEffectsFalseNoWarningInNodeModulesIssue999
---------- /out.js ----------
Expand Down Expand Up @@ -462,6 +478,22 @@ var init_a = __esm({
// Users/user/project/src/entry.js
Promise.resolve().then(() => (init_a(), a_exports)).then((x) => assert(x.foo === "foo"));

================================================================================
TestPackageJsonSideEffectsFalsePluginResolver
---------- /out.js ----------
// Users/user/project/node_modules/demo-pkg2/helper.js
function __decorate(s) {
}

// Users/user/project/node_modules/demo-pkg2/cmp2.js
var Something2 = class {
};
__decorate(Something2);
var cmp2_default = Something2;

// Users/user/project/src/entry.js
console.log(cmp2_default);

================================================================================
TestPackageJsonSideEffectsFalseRemoveBareImportCommonJS
---------- /out.js ----------
Expand Down

0 comments on commit 2e013f4

Please sign in to comment.