Skip to content

Commit

Permalink
fix #1358: remove warning about source map comment
Browse files Browse the repository at this point in the history
  • Loading branch information
evanw committed Jun 8, 2021
1 parent 3a45460 commit 6b42c96
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -32,6 +32,10 @@

This feature was contributed by [@chriscasola](https://github.com/chriscasola).

* Remove a warning about unsupported source map comments ([#1358](https://github.com/evanw/esbuild/issues/1358))

This removes a warning that indicated when a source map comment couldn't be supported. Specifically, this happens when you enable source map generation and esbuild encounters a file with a source map comment pointing to an external file but doesn't have enough information to know where to look for that external file (basically when the source file doesn't have an associated directory to use for path resolution). In this case esbuild can't respect the input source map because it cannot be located. The warning was annoying so it has been removed. Source maps still won't work, however.

## 0.12.7

* Quote object properties that are modern Unicode identifiers ([#1349](https://github.com/evanw/esbuild/issues/1349))
Expand Down
1 change: 0 additions & 1 deletion internal/bundler/bundler.go
Expand Up @@ -577,7 +577,6 @@ func extractSourceMapFromComment(
}

// Anything else is unsupported
log.AddRangeWarning(&tracker, comment.Range, "Unsupported source map comment")
return logger.Path{}, nil
}

Expand Down

0 comments on commit 6b42c96

Please sign in to comment.