fix(css): single hyphen shouldn't be treated as css identifier #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1308
CSS spec
In CSS Selector level 4:
According to
<ident-token>
rules, single hyphen-
without quotes is not validident-token
which means"-"
shouldn't be unwrapped as-
. On the other hand,"-"
is a valid<string-token>
and a valid part of CSS attribute selector.Extra helpful informations about
CSS escape
in w3ccc @evanw