feat(splitting): support minChunkSize option #3302
Open
+178
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayZoneYour
force-pushed
the
feat/add_min_chunk_size_support
branch
from
b956b4b
to
a6fa07c
Compare
ArrayZoneYour
force-pushed
the
feat/add_min_chunk_size_support
branch
from
a6fa07c
to
8851bd5
Compare
|
@evanw This would be really high-impact for my team, as I believe that chunk size is the only thing preventing us from switching from Rollup to esbuild. You mentioned that you intended to eventually rework the linker to support more customizable chunking behavior -- would you be open to merging this solution as a stopgap for now? |
|
I tried to locally compile this and test it with out project, however, the result is not working. After enabling the minChunkSize some of the imports are no longer working. In my case the require_prop_types is not defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2901, #2419, related to #207
When there are many entry points, it is easy to generate some small chunks.
This MR try to land minChunkSize options to control the chunk size by source content size