Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API to create a custom esbuild CLI with plugins #3539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edewit
Copy link

@edewit edewit commented Dec 12, 2023

This is very important as it allows to create create a CLI version of esbuild with a custom set of Go Plugin (in our case we needed scss). Without it we have to fork esbuild and add it which is not very nice.

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

@edewit edewit changed the title added new runImpl that takes plugins Provide API to create a custom esbuild CLI with plugins Dec 21, 2023
@ia3andy
Copy link

ia3andy commented Dec 21, 2023

Thanks for creating this PR @edewit, this will help a lot!

pkg/cli/cli_impl.go Outdated Show resolved Hide resolved
pkg/cli/cli_impl.go Outdated Show resolved Hide resolved
@ia3andy
Copy link

ia3andy commented Jan 24, 2024

Hey @evanw,

Could you consider getting this in, it would allow us to package our own CLI with plugins (scss) using normal GO import instead of forking the whole repository.

Cheers!

edewit and others added 2 commits March 18, 2024 13:24
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Co-authored-by: Andy Damevin <ia3andy@gmail.com>
@ia3andy
Copy link

ia3andy commented May 6, 2024

@evanw ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants