Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated Deno APIs "Deno.stderr.rid" "Deno.isatty()" "Deno.run()" #3610

Closed
wants to merge 1 commit into from
Closed

Conversation

dbushell
Copy link

Deno v1.40.0 was released deprecating:

  • Deno.isatty()
  • Deno.stderr.rid

Deno.run was previously deprecated to be replaced with Deno.Command.

This PR does the minimum to replace the deprecated APIs and fixes #3609

I had to modify deno-tests.js to call esbuildNative.initialize() and esbuildNative.stop() only once before and after the tests. Deno test was complaing about "Leaking async ops" and failing the first test despite the asserts being true.

I think the child process read/write code could be smaller now (e.g. without the need for startWriteFromQueueWorker) but I haven't done any extra refactoring here.

@evanw
Copy link
Owner

evanw commented Jan 26, 2024

Sorry but I already started working on this before you created this PR. I am also not planning on dropping support for older versions of Deno like this. Closing in favor of #3611.

@evanw evanw closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno: Usage of deprecated API with >= Deno 1.40
2 participants