Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.17 drops support for node 10 and webpack #270

Closed
vsumner opened this issue Apr 20, 2020 · 6 comments · Fixed by #271
Closed

0.5.17 drops support for node 10 and webpack #270

vsumner opened this issue Apr 20, 2020 · 6 comments · Fixed by #271

Comments

@vsumner
Copy link

vsumner commented Apr 20, 2020

The latest version 0.5.17 has a breaking change for consumers who use webpack and are on node v10.x.

I've solved this by locking my version to 0.5.16.

Error: ./node_modules/source-map-support/source-map-support.js
--
  | Module not found: Error: Can't resolve 'worker_threads' in '.../node_modules/source-map-support'
  | resolve 'worker_threads' in '.../node_modules/source-map-support'
  | Parsed request is a module
@LinusU
Copy link
Collaborator

LinusU commented Apr 20, 2020

Hmm, this is interesting, the require is made dynamically and is inside a try/catch 🤔

Any ideas if there is anything we can do to tell WebPack that it doesn't need to be able to resolve it?

@LinusU
Copy link
Collaborator

LinusU commented Apr 20, 2020

@vsumner hmm, are you using WebPack to produce a bundle for Node.js or for the browser? 🤔

@LinusU
Copy link
Collaborator

LinusU commented Apr 20, 2020

@vsumner could you test if #271 fixes this for you?

@LinusU
Copy link
Collaborator

LinusU commented Apr 21, 2020

Fixed in 0.5.18

@vsumner
Copy link
Author

vsumner commented May 20, 2020

Sorry I missed this. @LinusU thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants