Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebPack compatibility by using dynamic require #271

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix WebPack compatibility by using dynamic require #271

merged 1 commit into from
Apr 21, 2020

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented Apr 20, 2020

Fixes #270

We might want to use this for fs as well 馃

This was referenced Apr 20, 2020
Closed
Closed
@thib3113
Copy link

I've try on my app (react / webpack) :
With 0.5.17

./node_modules/source-map-support/source-map-support.js
Module not found: Can't resolve 'worker_threads' in 'C:\Users\thib3113\repos\project\node_modules\source-map-support'

And with this PR, no warning that seems good :) . Waiting for this to be merge :) .

@LinusU
Copy link
Collaborator Author

LinusU commented Apr 21, 2020

@thib3113 perfect, thanks for testing!

@LinusU LinusU merged commit 19257f6 into master Apr 21, 2020
@LinusU LinusU deleted the dynamic-require branch April 21, 2020 16:26
@LinusU
Copy link
Collaborator Author

LinusU commented Apr 21, 2020

Released as 0.5.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.5.17 drops support for node 10 and webpack
2 participants
@LinusU @thib3113