reduce sync io, only ignore foreseen errors #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulkish
commented
Jan 29, 2019
| @@ -88,12 +88,14 @@ retrieveFileHandlers.push(function(path) { | |||
| if (xhr.readyState === 4 && xhr.status === 200) { | |||
| contents = xhr.responseText; | |||
| } | |||
| } else if (fs.existsSync(path)) { | |||
| } else { | |||
There was a problem hiding this comment.
both usages of fs.readFileSync are already inside a try/catch block, it's safe to just let them try the read - a missing file error (ENOENT) gets swallowed anyway
|
Hmm, I wonder if this should be a breaking change or not 🤔 What do you think? It might throw now when it didn't before... |
|
@LinusU I can understand if that's what is decided. Though, personally i view this as a fix. |
|
I suppose on principle alone its always better to play this safe... Basically this could "break" downstreams since all errors were being swallowed, before. Though, i would argue this would be a legitimate break - but probably better to release as major bump |
|
@evanw thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.existsSyncpreceding afs.readFileSyncis 2 sync io operations that can/should be 1.ENEONT) errors should be swallowedEACCESSis swallowed.