Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace source-map with @jridgewell/trace-mapping #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onigoetz
Copy link

@onigoetz onigoetz commented Jun 1, 2022

The trace-mapping module is faster than source-map in every benchmark
https://github.com/jridgewell/trace-mapping#benchmarks

It's also being adopted by many packages across the ecosystem (Jest, Babel, Terser at least have included it already)
And it doesn't need to be async like source-map 0.7.*

This would replace #286 and #206

Regarding the changes in this PR

  • This project seems to have a wide compatibility with older Node.js versions, is that still needed ?
  • I tested the changes with the browsers tests but they failed, but I also tested /without/ my changes and it still failed (on Firefox, does it only work on some browsers ? )

@SimenB
Copy link
Contributor

SimenB commented Sep 9, 2023

@LinusU thoughts on this? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants