Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle startup errors #4383

Merged
merged 30 commits into from Sep 22, 2022
Merged

Gracefully handle startup errors #4383

merged 30 commits into from Sep 22, 2022

Conversation

andig
Copy link
Member

@andig andig commented Sep 11, 2022

If startup fails, show GUI for 5 minutes, then restart. Fatal error messages (fatal) will be displayed to aid new users with diagnosis.

Todo

  • differentiate no config (show demo) vs broken config (show fatal error)
  • expose fatal gui (@naltatis)
  • rework configured check (@naltatis)
  • shutdown endpoint -> POST /api/shutdown (@andig)
  • translation texts (@naltatis)
  • show anonymised config

Refs spf13/viper#1433, go-yaml/yaml#760

@andig andig added the enhancement New feature or request label Sep 11, 2022
@andig andig requested a review from naltatis September 11, 2022 13:25
@naltatis
Copy link
Member

yaml parsing errors should also result in readable error message, currently the process exists on invalid yamls.

Example:

While parsing config: yaml: line 57: did not find expected '-' indicator

@andig
Copy link
Member Author

andig commented Sep 17, 2022

yaml parsing errors should also result in readable error message, currently the process exists on invalid yamls.

Gute Idee! Done.

@naltatis
Copy link
Member

naltatis commented Sep 20, 2022

Nicer design for error page.

Bildschirmfoto 2022-09-20 um 21 46 37

@andig The restart button calls /api/shutdown which does not exist yet.

@andig
Copy link
Member Author

andig commented Sep 20, 2022

Der PR enthält komische Dinge- hast du neAhnung, wieso?

@naltatis
Copy link
Member

improved startup screen

@andig andig merged commit 479a3ed into master Sep 22, 2022
@andig andig deleted the feature/startup branch September 22, 2022 15:18
mabunixda added a commit to mabunixda/evcc that referenced this pull request Sep 23, 2022
* master:
  Fix resetOnDisconnect overriding default vehicle properties (evcc-io#4551)
  chore: add lint timeout
  more concise button
  Gracefully handle startup errors (evcc-io#4383)
  Add Solarwatt EnergyManager/Pro (evcc-io#4538)
  Fronius Gen24: simplify (evcc-io#4510)
  Telemetry: add green power
  Ford: handle login errors
  Telemetry: log Wh instead of kWh
  Telemetry: send only if above standby power
  Telemetry: switch to bearer auth
  Telemetry: improve naming
  Revert "SE: fix hybrid template (evcc-io#4503)" (evcc-io#4528)
  Allow Credentials (Basic Auth) for manifest.json (evcc-io#4525)
  Experimental: add telemetry for virtual power plant (evcc-io#4343)
  Easee: simplify smart charging
  OpenEVSE: fix null pointer (evcc-io#4515)
@premultiply
Copy link
Member

premultiply commented Sep 30, 2022

Könnte man in der Darstellung der Konfigdatei noch die Zeilennummern vorne mit angegeben?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants