Add additional argument for generating msgstr in order to create *.po files #45
Conversation
…r- allows generating pre-translated PO files
…ue-handling formatters
|
Would you mind providing more details about your translation workflow? |
|
Well, I'm sure you know a |
|
Just a reminder that there is already a built in algorithm working internally of Anyway, thanks for sharing the process of your project, and it's ok for me to merge this PR if it is ready. :) |
|
Yeah, so many options aren't there! Ready to merge if you're happy to have these features in the core project (: |
|
Yeah, so many options aren't there! Well I'm ready if you are and you're On Mon, Oct 24, 2016 at 8:41 PM Michael Hsu notifications@github.com
|
| }); | ||
|
|
||
| test('should return pot formatted string', t => { | ||
| t.is( | ||
| potFormater({ | ||
| potFormater(null)({ |
There was a problem hiding this comment.
Add another test case for custom messageValue will be great. :)
| Object.keys(messageObject) // return array of id | ||
| .sort() | ||
| .map(id => `${potCommentsFormater(messageObject[id])}msgid "${id}"\nmsgstr ""\n`) | ||
| .map(id => `${potCommentsFormater(messageObject[id])}msgid "${id}"\nmsgstr "${messageValue ? messageObject[id][0][messageValue] : ''}"\n`) |
There was a problem hiding this comment.
There is an eslint error here, please fix it or alternatively just adding one line eslint-disable for pretty display. :)
ps: Rebase onto master branch which now using node v6 and npm v3 and just run npm run lint locally.
No description provided.