Skip to content

Commit

Permalink
Small improvement.
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolad committed Feb 9, 2021
1 parent 181609d commit 8999e99
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
# TODO replace this when setup-node action supports LTS alias
- name: Set up Node
uses: dcodeIO/setup-node-nvm@master
if: 'false'
with:
node-version: lts/*

Expand All @@ -32,14 +33,17 @@ jobs:

- name: Install dependencies
# install deps only if lockfile has changed
if: steps.cache-deps.outputs.cache-hit != 'true'
# if: steps.cache-deps.outputs.cache-hit != 'true'
if: 'false'
run: yarn install --frozen-lockfile

- name: Set test CLI args
if: ${{ matrix.task == 'test' }}
if: 'false'
run: echo "CLI_ARGS=--changedSince ${{ github.event.pull_request.base.sha }}" >> $GITHUB_ENV

- name: Run ${{ matrix.task }}
if: 'false'
run: yarn ${{ matrix.task }}:ci ${{ env.CLI_ARGS }}
e2e:
name: E2E Tests
Expand Down
15 changes: 0 additions & 15 deletions tools/deploy-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,6 @@ rm -rf $CLONE_DIR/*
# clone the repo branch
git clone -b $BRANCH https://$API_TOKEN_GITHUB@github.com/$USERNAME/$REPO.git $CLONE_DIR

## DEPLOY I18N ##
## make sure languages directory exists
mkdir -p $CLONE_DIR/languages
# paths of the translation files
PHP_I18N_FILE="$CLONE_DIR/languages/event_espresso-translations-js.php"
JS_I18N_FILE="$BASE/$BUILD_PATH/js-translations.pot"
# make sure the file exists
touch $PHP_I18N_FILE
# Convert POT file to PHP
echo "Converting pot to PHP..."
npx pot-to-php $JS_I18N_FILE $PHP_I18N_FILE event_espresso
# Remove POT file
echo "Remove JS pot file"
rm $JS_I18N_FILE

# goto the repo directory
cd $CLONE_DIR

Expand Down

0 comments on commit 8999e99

Please sign in to comment.