Skip to content

Commit

Permalink
Partly fixed white line in dark mode bug 馃悰
Browse files Browse the repository at this point in the history
Caught up with electron/electron#13164.
The eventual fix seems to have to come from Apple (--> Catalina).
  • Loading branch information
evertdespiegeleer committed Jul 19, 2019
1 parent 41faeb8 commit 26cd3c9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -12,7 +12,8 @@ PrettyEarth is [Electron](https://electronjs.org/) based. It is, to be more part
Currently, only macOS is supported. However, adaptation on other operating systems will be provided soon. Few modifications are needed.

### known issues and future developements
- [ ] [macOS Mojave titlebar issue](https://github.com/electron/electron/issues/15008) (Electron related)
- [ ] [macOS Mojave white line issue in dark mode](https://github.com/electron/electron/issues/15008) (Electron related)
The Electron team have done what they could. The problem is reduced. The infamous line has become very thin and less noticeable. The underlying problem is OS-related. [Apple will probably fix the issue in Catalina.](https://github.com/electron/electron/issues/13164#issuecomment-500081463)
- [ ] Windows support

## Build
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -7,7 +7,7 @@
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"start": "electron .",
"package-mac": "electron-packager . --overwrite --platform=darwin --arch=x64 --out=dist --icon=icon.icns --ignore='^/docs|^/dist|^/design'"
"package-mac": "electron-packager . --overwrite --platform=darwin --arch=x64 --out=dist --icon=icon.icns --ignore='^/docs|^/dist|^/design' --darwinDarkModeSupport=true"
},
"author": "Evert De Spiegeleer",
"license": "MIT",
Expand Down

0 comments on commit 26cd3c9

Please sign in to comment.