feat(filter-options): Add --exclude-dependents option

Footguns abound. Fixes lerna#2198
evocateur · Oct 7, 2019 · 62df43f · 62df43f
1 parent 3657a8b
commit 62df43f
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 4 deletions.
diff --git a/commands/add/__tests__/add-command.test.js b/commands/add/__tests__/add-command.test.js
@@ -290,6 +290,7 @@ describe("AddCommand", () => {
         ignore: undefined,
         private: undefined,
         since: undefined,
+        excludeDependents: undefined,
         includeFilteredDependents: undefined,
         includeFilteredDependencies: undefined,
       })

diff --git a/commands/add/index.js b/commands/add/index.js
@@ -105,6 +105,7 @@ class AddCommand extends Command {
           ignore: undefined,
           private: undefined,
           since: undefined,
+          excludeDependents: undefined,
           includeFilteredDependents: undefined,
           includeFilteredDependencies: undefined,
         });

diff --git a/core/filter-options/index.js b/core/filter-options/index.js
@@ -35,11 +35,20 @@ function filterOptions(yargs) {
       `,
       type: "string",
     },
+    "exclude-dependents": {
+      describe: dedent`
+        Exclude all transitive dependents when running a command
+        regardless of --scope, --ignore, or --since.
+      `,
+      conflicts: "include-dependents",
+      type: "boolean",
+    },
     "include-filtered-dependents": {
       describe: dedent`
         Include all transitive dependents when running a command
         regardless of --scope, --ignore, or --since.
       `,
+      conflicts: "exclude-dependents",
       type: "boolean",
     },
     "include-filtered-dependencies": {

diff --git a/core/filter-options/lib/get-filtered-packages.js b/core/filter-options/lib/get-filtered-packages.js
@@ -24,6 +24,10 @@ function getFilteredPackages(packageGraph, execOpts, options) {
   if (options.since !== undefined) {
     log.notice("filter", "changed since %j", options.since);
 
+    if (options.excludeDependents) {
+      log.notice("filter", "excluding dependents");
+    }
+
     chain = chain.then(filteredPackages =>
       Promise.resolve(collectUpdates(filteredPackages, packageGraph, execOpts, options)).then(updates => {
         const updated = new Set(updates.map(({ pkg }) => pkg.name));

diff --git a/utils/collect-updates/collect-updates.js b/utils/collect-updates/collect-updates.js
@@ -13,7 +13,7 @@ module.exports.collectPackages = collectPackages;
 module.exports.getPackagesForOption = getPackagesForOption;
 
 function collectUpdates(filteredPackages, packageGraph, execOpts, commandOptions) {
-  const { forcePublish, conventionalCommits, conventionalGraduate } = commandOptions;
+  const { forcePublish, conventionalCommits, conventionalGraduate, excludeDependents } = commandOptions;
 
   // If --conventional-commits and --conventional-graduate are both set, ignore --force-publish
   const useConventionalGraduate = conventionalCommits && conventionalGraduate;
@@ -69,6 +69,7 @@ function collectUpdates(filteredPackages, packageGraph, execOpts, commandOptions
 
     return collectPackages(packages, {
       onInclude: name => log.verbose("updated", name),
+      excludeDependents,
     });
   }
 
@@ -86,5 +87,6 @@ function collectUpdates(filteredPackages, packageGraph, execOpts, commandOptions
   return collectPackages(packages, {
     isCandidate: (node, name) => isForced(node, name) || needsBump(node) || hasDiff(node),
     onInclude: name => log.verbose("updated", name),
+    excludeDependents,
   });
 }
diff --git a/utils/collect-updates/lib/collect-packages.js b/utils/collect-updates/lib/collect-packages.js
@@ -4,7 +4,7 @@ const collectDependents = require("./collect-dependents");
 
 module.exports = collectPackages;
 
-function collectPackages(packages, { isCandidate = () => true, onInclude } = {}) {
+function collectPackages(packages, { isCandidate = () => true, onInclude, excludeDependents } = {}) {
   const candidates = new Set();
 
   packages.forEach((node, name) => {
@@ -13,8 +13,9 @@ function collectPackages(packages, { isCandidate = () => true, onInclude } = {})
     }
   });
 
-  const dependents = collectDependents(candidates);
-  dependents.forEach(node => candidates.add(node));
+  if (!excludeDependents) {
+    collectDependents(candidates).forEach(node => candidates.add(node));
+  }
 
   // The result should always be in the same order as the input
   const updates = [];