Revert 6f1cae9 because it caused a lot of troubles... #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @andreassolberg - can you maybe write a regression test for the case that broke for you so we can ensure that whenever we change the function again it will work for your use-case? -> https://github.com/evseevnn/php-cassandra-binary/blob/master/tests/Cases/PositiveIntTest.php and https://github.com/evseevnn/php-cassandra-binary/blob/master/tests/Cases/NegativeIntTest.php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #35
Someone should take a closer look at what the 6f1cae9 did intend to fix, and reapply a patch that does not break so fundamentally.
It might very be that these issues only affect more recent versions of cassandra, as not all users are experiencing them. See #35 and 6f1cae9 for more details.