New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow custom image resource path #24

Open

JumpLink wants to merge 2 commits into excaliburjs:main from PixelRPG:feature/image-path

JumpLink commented Nov 1, 2021

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Closes #23

Changes:

Added optional parameter to the constructor of AsepriteResource to allow to overwrite the image path. E.g. to resolve the image path by the build tool.
Split frame type in AsepriteRaw to AsepriteRawFrame
Do not throw an error if frameTags is not defined

JumpLink added 2 commits

November 1, 2021 12:45


          feat: Allow custom image resource path

4c0fb91


          chore: revert package-lock.json changes from npm >= 7

020dc01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment